Include javadoc & groovydoc in the same jar and restore source inclusion #1878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdaugherty
force-pushed
the
sourceAndJavadocFix
branch
from
540eebd to
7600354
Compare
Contributor
Author
|
apache/grails-gradle-plugin#399 will make jar changes I'm removing here unnecessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matrei with the gradle plugin fixes, we can now restore the source & javadoc jars. We still need to include the groovydoc in the javadoc jar though. This may make sense to be part of a gradle plugin.
Also, with the changes to the gradle plugin, anyone who was one off registering a jar task but not including the javadoc task, will be missing sources. I am going to enhance the gradle plugin to handle these scenarios so they are included in either case.