Unnest the snapshot zip uploaded to workflow results#595
Merged
jamesfredley merged 1 commit into7.0.xfrom Jun 13, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Gradle GitHub Actions workflow to upload unpacked snapshot artifacts (including hidden files) rather than a single ZIP.
- Adds
include-hidden-files: trueto ensure all files are captured. - Changes the upload path to
tmp1/cli/**/*to upload unarchived snapshot contents.
Comments suppressed due to low confidence (2)
.github/workflows/gradle.yml:65
- A step to unzip the generated snapshot ZIP into
tmp1/cli/is missing. Add an unzip command (e.g.,unzip grails-cli/build/distributions/apache-grails-*.zip -d tmp1/cli) before uploading so that the path contains the expected files.
path: tmp1/cli/**/*
.github/workflows/gradle.yml:63
- [nitpick] The artifact
namestill ends with.zipbut you’re uploading a directory. Consider renaming it to remove the extension or reflect the folder content (e.g.,apache-grails-SNAPSHOT-incubating-bin).
name: 'apache-grails-SNAPSHOT-incubating-bin.zip'
jdaugherty
reviewed
Jun 12, 2025
jdaugherty
reviewed
Jun 12, 2025
matrei
approved these changes
Jun 12, 2025
jdaugherty
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample from workflow run: https://github.com/apache/grails-forge/actions/runs/15619619727/artifacts/3317483009
vs
https://github.com/apache/grails-forge/actions/runs/15592561305/artifacts/3308182824