Update mysql driver maven coordinates#597
Merged
jamesfredley merged 1 commit into7.0.xfrom Jun 17, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Maven coordinates for the MySQL driver from the old mysql:mysql-connector-java to the new com.mysql:mysql-connector-j across tests and the feature implementation.
- Adjust template assertion in
MySQLSpecto use the new coordinates - Update expected dependency string in
GradleDependencyComparatorSpec - Change
groupIdandartifactIdin theMySQLfeature’sapplymethod
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| grails-forge-core/src/test/groovy/org/grails/forge/feature/database/MySQLSpec.groovy | Updated template check to new Maven coordinates |
| grails-forge-core/src/test/groovy/org/grails/forge/build/dependencies/GradleDependencyComparatorSpec.groovy | Updated expected Gradle dependency string |
| grails-forge-core/src/main/java/org/grails/forge/feature/database/MySQL.java | Changed dependency builder to new MySQL coordinates |
matrei
approved these changes
Jun 17, 2025
sbglasius
approved these changes
Jun 17, 2025
jdaugherty
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update from mysql:mysql-connector-java to com.mysql:mysql-connector-j
Version https://docs.grails.org/7.0.0-M4/ref/Versions/Grails%20BOM.html comes from
spring-boot-dependencies via grails-bom