Closed
Conversation
The index.adoc header links were hardcoded to Spring Security 4.0.x and Spring Framework 4.1.x. Replace with AsciiDoc attributes populated from the BOM-resolved version in docs/build.gradle. Also add a NOTE comment about configuration-time dependency resolution in the docs build. Assisted-by: Claude Code <Claude@Claude.ai>
Each plugin docs/build.gradle applied reproducible-config.gradle twice:
once at the top level and again inside an apply {} block left over from the
docs-config.gradle refactor.
Assisted-by: Claude Code <Claude@Claude.ai>
Assisted-by: Claude Code <Claude@Claude.ai>
jamesfredley
force-pushed
the
fix/doc-combination-review
branch
from
f392295 to
4c120c7
Compare
Contributor
|
Merged into my branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review fixes for #1211. Merge this into
doc-combinationbefore merging that PR.index.adocheader links were hardcoded to Spring Security 4.0.x and Spring Framework 4.1.x. Now uses AsciiDoc attributes populated from the BOM-resolved version indocs/build.gradle.reproducible-config.gradleapplies - All 7 plugindocs/build.gradlefiles applied it twice: once at the top level and again inside anapply {}block left over from thedocs-config.gradlerefactor.whatsNew.adoc