Skip to content

Conversation

@yuqi1129
Copy link
Contributor

@yuqi1129 yuqi1129 commented Jan 5, 2026

What changes were proposed in this pull request?

This pull request adds a new documentation page that explains how to integrate the Lance REST service with Spark and Ray using their respective connectors. The guide covers prerequisites, compatibility, example usage for both Spark and Ray, troubleshooting tips, and a compatibility matrix for versions.

Why are the changes needed?

For a better user experience
Fix: #9622

Does this PR introduce any user-facing change?

N/A.

How was this patch tested?

N/A.

Copilot AI review requested due to automatic review settings January 5, 2026 08:57
@yuqi1129 yuqi1129 marked this pull request as draft January 5, 2026 08:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jan 6, 2026

@yuqi1129 yuqi1129 self-assigned this Jan 7, 2026
@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jan 8, 2026

@yuqi1129 yuqi1129 marked this pull request as ready for review January 9, 2026 11:25
@yuqi1129 yuqi1129 added the branch-1.1 Automatically cherry-pick commit to branch-1.1 label Jan 9, 2026
@yuqi1129 yuqi1129 requested a review from Copilot January 9, 2026 11:50
@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jan 9, 2026

This PR will be blocked by several bugs and improvement, the followings are:

The first two have been resolved.

All resolved and ready to review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

@yuqi1129 yuqi1129 requested review from jerryshao and mchades January 9, 2026 12:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.

Comment on lines +126 to +127
The `LOCATION` clause in the `CREATE TABLE` statement is optional. When omitted, lance-spark automatically determines an appropriate storage location based on catalog properties.
For detailed information on location resolution logic, refer to the [Lakehouse Generic Catalog documentation](./lakehouse-generic-catalog.md#key-property-location).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this chapter belong to local storage? Also, as I remembered, external table must specify the location, am I right?

Copy link
Contributor Author

@yuqi1129 yuqi1129 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as I remembered, external table must specify the location, am I right?

I'm afraid not. According to the code base, whether it's an external or not, the calculation method is the same: If no location is specified in table level, it will try to use the location of its parent, like the schema or catalog. It seems that we only use the property external when droping or purging the table.

public Table createTable(
NameIdentifier ident,
Column[] columns,
String comment,
Map<String, String> properties,
Transform[] partitions,
Distribution distribution,
SortOrder[] sortOrders,
Index[] indexes)
throws NoSuchSchemaException, TableAlreadyExistsException {
Schema schema = loadSchema(NameIdentifier.of(ident.namespace().levels()));
String tableLocation = calculateTableLocation(schema, ident, properties);
String format = properties.getOrDefault(Table.PROPERTY_TABLE_FORMAT, null);

external table must specify the location

Do you mean users need to specify the location in the table explicitly, or do they set it on any of the catalog, schema, or table?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

@jerryshao jerryshao requested a review from mchades January 21, 2026 18:06
@yuqi1129 yuqi1129 merged commit 209001c into apache:main Jan 22, 2026
23 checks passed
@yuqi1129 yuqi1129 deleted the issue_9622 branch January 22, 2026 13:05
github-actions bot pushed a commit that referenced this pull request Jan 22, 2026
…Spark and Ray (#9623)

### What changes were proposed in this pull request?

This pull request adds a new documentation page that explains how to
integrate the Lance REST service with Spark and Ray using their
respective connectors. The guide covers prerequisites, compatibility,
example usage for both Spark and Ray, troubleshooting tips, and a
compatibility matrix for versions.


### Why are the changes needed?

For a better user experience
Fix: #9622

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

N/A.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch-1.1 Automatically cherry-pick commit to branch-1.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Add docs about integration with Lance REST service

3 participants