[#9894] feat (trino-connector): Add the version segment module to support Trino 440-445#9895
Open
diqiu50 wants to merge 6 commits intoapache:branch-trino-smvfrom
Open
[#9894] feat (trino-connector): Add the version segment module to support Trino 440-445#9895diqiu50 wants to merge 6 commits intoapache:branch-trino-smvfrom
diqiu50 wants to merge 6 commits intoapache:branch-trino-smvfrom
Conversation
…version management - Add new trino-connector-440-445 module supporting Trino versions 440-445 - Implement version-specific adapters (GravitinoPlugin440, GravitinoConnectorFactory440, etc.) - Fix GravitinoMetadata440.beginMerge() to wrap return value as GravitinoMergeTableHandle - Update finishInsert() signature to include sourceTableHandles parameter (Trino 440+ API change) - Fix SPI configuration file path to META-INF/services/io.trino.spi.Plugin - Add complete distribution tasks (assembleTrinoConnector, checksumTrinoConnector) Version management optimization: - Simplify version validation logic using minTrinoVersion and maxTrinoVersion - Remove dependency on global minSupportedTrinoVersion property - Each module now independently manages its version range - Improve error messages with clear version range information - Apply optimization to both 435-439 and 440-445 modules Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Fix typo: createGravitinoPulgin -> createGravitinoPlugin - Ensures test methods correctly override parent class methods Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Change addColumn method to throw TrinoException directly instead of wrapping in RuntimeException - Properly propagate TrinoException from reflection invocation - Add throws declaration to method signature This fix resolves test failures where TrinoException was being wrapped unnecessarily. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for Trino versions 440-445 by creating a new version segment module trino-connector-440-445. The implementation follows the established pattern used in the existing trino-connector-435-439 module.
Changes:
- Created new module
trino-connector-440-445with version-specific connector implementations for Trino 440-445 - Updated build configuration for the
trino-connector-435-439module to improve clarity - Fixed exception handling in
GravitinoMockServer.javato properly re-throwTrinoExceptioninstead of wrapping it
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Added new trino-connector-440-445 module to the project |
| trino-connector/trino-connector-435-439/build.gradle.kts | Refactored version range validation for consistency with the new 440-445 module |
| trino-connector/trino-connector-440-445/build.gradle.kts | New build configuration for Trino 440-445 support, consistent with 435-439 module |
| trino-connector/trino-connector-440-445/src/main/java/org/apache/gravitino/trino/connector/GravitinoPlugin440.java | Entry point plugin class for Trino 440-445 |
| trino-connector/trino-connector-440-445/src/main/java/org/apache/gravitino/trino/connector/GravitinoConnectorFactory440.java | Factory class that creates connectors for Trino versions 440-445 |
| trino-connector/trino-connector-440-445/src/main/java/org/apache/gravitino/trino/connector/GravitinoConnector440.java | Main connector implementation with version-specific metadata and split manager |
| trino-connector/trino-connector-440-445/src/main/java/org/apache/gravitino/trino/connector/GravitinoMetadata440.java | Metadata adapter implementing Trino 440+ API changes (e.g., finishInsert with sourceTableHandles parameter) |
| trino-connector/trino-connector-440-445/src/main/java/org/apache/gravitino/trino/connector/GravitinoSplitManager440.java | Split manager implementation with version-specific getInfo() override |
| trino-connector/trino-connector-440-445/src/main/java/org/apache/gravitino/trino/connector/GravitinoSystemConnector440.java | System connector for internal Gravitino tables and procedures |
| trino-connector/trino-connector-440-445/src/main/java/org/apache/gravitino/trino/connector/GravitinoNodePartitioningProvider440.java | Node partitioning provider for distributed query execution |
| trino-connector/trino-connector-440-445/src/main/resources/META-INF/services/io.trino.spi.Plugin | SPI service registration for GravitinoPlugin440 |
| trino-connector/trino-connector-440-445/src/test/java/TestGravitinoConnector440.java | Test class extending base connector tests for Trino 440 |
| trino-connector/trino-connector/src/test/java/org/apache/gravitino/trino/connector/GravitinoMockServer.java | Improved exception handling to properly re-throw TrinoException |
|
|
||
| private void addColumn( | ||
| ConnectorMetadata metadata, ConnectorTableHandle tableHandle, ColumnMetadata columnMetadata) { | ||
| ConnectorMetadata metadata, ConnectorTableHandle tableHandle, ColumnMetadata columnMetadata) throws TrinoException{ |
There was a problem hiding this comment.
Missing space before opening brace. According to Google Java Style Guide, there should be a space between the closing parenthesis and the opening brace of the throws clause.
Suggested change
| ConnectorMetadata metadata, ConnectorTableHandle tableHandle, ColumnMetadata columnMetadata) throws TrinoException{ | |
| ConnectorMetadata metadata, ConnectorTableHandle tableHandle, ColumnMetadata columnMetadata) throws TrinoException { |
- Add connectionTimeout and socketTimeout configuration (300 seconds) - Fixes CI failures when downloading Java 24 toolchain from Foojay API - Resolves SocketTimeoutException in GitHub Actions environment
Apply Spotless formatting to improve code readability by splitting long method signature across multiple lines. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
yuqi1129
reviewed
Feb 5, 2026
Contributor
yuqi1129
left a comment
yuqi1129
left a comment
There was a problem hiding this comment.
Another point is that Is poissble to add some tests for Trino 440 to 445.
|
|
||
| trino: | ||
| image: trinodb/trino:${TRINO_VERSION:-435} | ||
| image: trinodb/trino:${TRINO_VERSION:-440} |
Contributor
There was a problem hiding this comment.
How can we support multiple versions since you changed it from 435 to 440? will you change it again when you support Trino 446 to 450.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the version segment module for 440-445 to support Trino 440 through Trino 445
Why are the changes needed?
Fix: #9894
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT and IT