Skip to content

GROOVY-11508: change exception to detailed warning #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

GROOVY-11508: change exception to detailed warning #2117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22ad876
GROOVY-11508: change exception to detailed warning
jamesfredley Oct 24, 2024
246146c
remove extra space
jamesfredley Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/main/java/org/codehaus/groovy/classgen/Verifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
import java.util.ListIterator;
import java.util.Map;
import java.util.Set;
import java.util.logging.Logger;

import static java.lang.reflect.Modifier.isFinal;
import static java.lang.reflect.Modifier.isPrivate;
Expand Down Expand Up @@ -149,6 +150,8 @@
*/
public class Verifier implements GroovyClassVisitor, Opcodes {

private static final Logger LOG = Logger.getLogger(Verifier.class.getName());

public static final String SWAP_INIT = "__$swapInit";
public static final String STATIC_METACLASS_BOOL = "__$stMC";
public static final String INITIAL_EXPRESSION = "INITIAL_EXPRESSION";
Expand Down Expand Up @@ -364,9 +367,9 @@ private static void checkForDuplicateInterfaces(final ClassNode cn) {
if (t.equals(in)) {
String one = in.toString(false), two = t.toString(false);
if (!one.equals(two))
throw new RuntimeParserException("The interface " + in.getNameWithoutPackage() +
" cannot be implemented more than once with different arguments: " + one + " and " + two, cn);
break;
LOG.warning("Warning: " + "on " + cn.getName() + " the interface " + in.getNameWithoutPackage() +
" was implemented more than once with different arguments: " + one + " and " + two + ", " +
cn.getName() + " will only implement the lowest level " + in.getNameWithoutPackage());
}
}
}
Expand Down