-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19012. Use CRC tables to speed up galoisFieldMultiply in CrcUtil. #8011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
@slfan1989 , @steveloughran , trunk compilation failed. Do you know why? |
💔 -1 overall
This message was automatically generated. |
@szetszwo Thank you for reporting this issue. I checked the compilation information and saw the following error:
It was caused by This is related to the Guava version upgrade in the trunk.
The dependency I submitted #8015 to fix this issue. |
Description of PR
HADOOP-19012
(Resubmitting #6542 )
CrcUtil.galoisFieldMultiply(p, q, m) supports multiplying two polynomials p, q modulo any modulus polynomial m over GF(2). Since the method is used for CRC calculations, the modulus polynomial m is restricted to either the GZIP_POLYNOMIAL or the CASTAGNOLI_POLYNOMIAL. We may use CRC tables in PureJavaCrc32/PureJavaCrc32C to speed up the computation.
How was this patch tested?
Added new tests.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?