Skip to content

HBASE-30010 Edit on GitHub link Not Found #7961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liuxiaocs7 wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

HBASE-30010 Edit on GitHub link Not Found #7961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hbase-website/app/pages/_docs/docs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ const renderer = toClientRenderer(

{route !== undefined && (
<a
href={`https://github.com/apache/hbase/${baseGithubPath}${mdxFileRoute}`}
href={`https://github.com/apache/hbase/edit/master/${baseGithubPath}${mdxFileRoute}`}
rel="noreferrer noopener"
target="_blank"
Comment on lines 257 to 261
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new GitHub URL uses /edit/master/ but mdxFileRoute can be empty for single-page routes and can point to a non-existent file for grouped section roots (e.g., /docs/architecture resolves to architecture.mdx even though the repo has architecture/index.mdx). In both cases this will still produce a GitHub 404. Consider deriving the actual source file path based on the route: use the single-page/index.mdx file for single-page views, and use ${trimmedRoute}/index.mdx (or equivalent) when the route maps to a directory index page, so the edit link always targets a real file.

Copilot uses AI. Check for mistakes.
className="text-fd-secondary-foreground bg-fd-secondary hover:text-fd-accent-foreground hover:bg-fd-accent w-fit rounded-xl border p-2 text-sm font-medium transition-colors"
Expand Down
Loading