Document performance characteristics and safe usage patterns for messaging service API#3085
Open
PranaviAncha wants to merge 4 commits intoapache:masterfrom
Open
Document performance characteristics and safe usage patterns for messaging service API#3085PranaviAncha wants to merge 4 commits intoapache:masterfrom
PranaviAncha wants to merge 4 commits intoapache:masterfrom
Conversation
PranaviAncha
commented
Dec 5, 2025
PranaviAncha
commented
Dec 5, 2025
|
Please check on the java doc publishing. I do not think JAVA docs are published for any of the version |
junkaixue
requested changes
Dec 9, 2025
Contributor
junkaixue
left a comment
There was a problem hiding this comment.
I would suggest to split the code out the documentation pr. This PR seemed to be mixing of them hard to review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
(#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
Description
What
Documents the non-optimized behavior of Criteria evaluation in the messaging API.
Why
Criteria evaluation scans all ExternalView znodes when using wildcards, even for instance-only targeting. This causes severe performance degradation at scale but isn't documented, leading users to unknowingly introduce performance issues.
Tests
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)