HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported … #6259
Conversation
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
…for Iceberg table
ramitg254
changed the title
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
tests failed
labels
|
| return null; | ||
| } | ||
|
|
||
| private Partition getPartition(Table tab, Map<String, String> partitionSpec) throws HiveException { |
There was a problem hiding this comment.
The logic here is almost same as getPartition() in DescTableOperation.java https://github.com/apache/hive/pull/6259/changes#diff-641c62b42b01bff41c89a3b3661c15d6c08fce0e48740347f36fe32448984147R131
Check if you can add them in an utility so it can be reused
soumyakanti3578
left a comment
soumyakanti3578
left a comment
There was a problem hiding this comment.
DDLUtils.isIcebergTable() has been used in many places in the compiler. I think we should not use a specific table type here.
| } | ||
|
|
||
| private Partition getPartition(Table tab, Map<String, String> partitionSpec) throws HiveException { | ||
| boolean isIcebergTable = DDLUtils.isIcebergTable(tab); |
There was a problem hiding this comment.
Please don't use DDLUtils.isIcebergTable as this API in the compiler is too specific. Instead please use tab.isNonNative() in conjunction to other APIs if needed.
4 participants
…for Iceberg table
What changes were proposed in this pull request?
Adds support for using partition spec with describe statement for iceberg table.
and updated the other test outputs as partition information is also gettting printed for desc statement after the changes
Why are the changes needed?
currently using partition spec with describe statement for iceberg table result in unsupported exception
Does this PR introduce any user-facing change?
yes, this statement will not result in exception anymore
How was this patch tested?
build locally and ci tests and added q tests