HIVE-29399: Remove SqlSyntax.FUNCTION_STAR from AVG and SUM functions #6262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
zabetak
changed the title
Member
Author
|
Hey @soumyakanti3578 , since you are familiar with HIVE-29339 can you please take a look on this small follow-up? |
|
soumyakanti3578
approved these changes
Jan 12, 2026
Contributor
soumyakanti3578
left a comment
soumyakanti3578
left a comment
There was a problem hiding this comment.
@zabetak LGTM, but do you think we need to add [ADDENDUM] to the title?
Member
Author
|
Many thanks for the review @soumyakanti3578 ! It's not necessary to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove special FUNCTION_STAR syntax from AVG and SUM functions since
AVG(*)andSUM(*)are explicitly not supported in Hive.Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests