Check for keep-alive option support #544
Merged
+61
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschmitt
added a commit
to rschmitt/httpcomponents-client
that referenced
this pull request
Aug 8, 2025
It turns out that keep-alive options are supported on all modern combinations of Java runtimes and operating systems, with the sole excpetion of Java 8 on Windows. The keep-alive options are specifically unavailable on this combination: you can refer to them in code, but attempting to set them will result in an UnsupportedOperationException. The good news is that there's a method we can call, `Sockets.supportedOptions()`, that returns a complete list of socket options supported by the current runtime. This change simply uses that functionality to check for support before setting keep-alive options on any socket.
rschmitt
added a commit
to rschmitt/httpcomponents-client
that referenced
this pull request
Aug 8, 2025
ok2c
approved these changes
Aug 8, 2025
|
@rschmitt Would not it be easier / neater just to catch and ignore |
garydgregory
reviewed
Aug 8, 2025
| @@ -89,4 +97,7 @@ public static int determineJRELevel() { | |||
| return 7; | |||
| } | |||
|
|
|||
| public static boolean supportsKeepAliveOptions() { | |||
There was a problem hiding this comment.
Missing Javadoc. Adding this here seems misleading since it's not related to reflection. Isn't there a better place?
There was a problem hiding this comment.
It's not literally reflection, but it is introspection of the current runtime capabilities, so I figured this was a close enough match and would save me the trouble of creating a new Utils class.
rschmitt
added a commit
to apache/httpcomponents-client
that referenced
this pull request
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that keep-alive options are supported on all modern combinations of Java runtimes and operating systems, with the sole excpetion of Java 8 on Windows. The keep-alive options are specifically unavailable on this combination: you can refer to them in code, but attempting to set them will result in an UnsupportedOperationException.
The good news is that there's a method we can call,
Sockets.supportedOptions(), that returns a complete list of socket options supported by the current runtime. This change simply uses that functionality to check for support before setting keep-alive options on any socket.