Fix hostname verification tests #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed after a macOS upgrade that these tests were failing, evidently due to some sort of firewall behavior. Looking at the problem, it seems like these tests actually intend to call `getLoopbackAddress`, rather than `getLocalHost`, which returns the IP address and hostname of the local host _on the network_, rather than on the loopback.
|
I think these tests are breaking due to an issue with my router, which is apparently returning a stale IP address when my hostname is queried over DNS. Nevertheless, I still think that |
ok2c
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed after a macOS upgrade that these tests were failing, evidently due to some sort of firewall behavior. Looking at the problem, it seems like these tests actually intend to call
getLoopbackAddress, rather thangetLocalHost, which returns the IP address and hostname of the local host on the network, rather than on the loopback.