feat: Add floor size file limit config to SparkSizeBasedClusteringPlanStrategy #17766
+266
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nsivabalan
reviewed
Jan 2, 2026
Contributor
nsivabalan
left a comment
nsivabalan
left a comment
There was a problem hiding this comment.
1 minor commend. LGTM otherwise
|
|
||
| public static final ConfigProperty<String> PLAN_STRATEGY_SMALL_FILE_FLOOR_LIMIT = ConfigProperty | ||
| .key(CLUSTERING_STRATEGY_PARAM_PREFIX + "small.file.floor.limit") | ||
| .defaultValue(String.valueOf(0L)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Introducing a new config
PLAN_STRATEGY_FLOOR_FILE_LIMITwhich only considers clustering on files greater than the specified limit. (Note this is to be used in conjuction with the existingPLAN_STRATEGY_SMALL_FILE_LIMITwhich only considers clustering on files less than the small file limit which acts as a ceiling).Summary and Changelog
PLAN_STRATEGY_FLOOR_FILE_LIMITgetFileSlicesEligibleForClusteringto use new configTestSparkSizeBasedClusteringWithFloorLimitfor testing this configImpact
none
Risk Level
low
Documentation Update
new config update
PLAN_STRATEGY_FLOOR_FILE_LIMITContributor's checklist