modify some details

Author: HeartLinked

.github/workflows/rc.yml

@@ -87,7 +87,7 @@ jobs:
       - name: Install C++ Build Tools (macOS)
         if: runner.os == 'macOS'
         run: |
-          brew install cmake ninja openssl
+          brew reinstall cmake ninja openssl
 
       - name: Checkout
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

dev/release/release.sh

@@ -38,6 +38,7 @@ rc=$2
 git_origin_url="$(git remote get-url origin)"
 repository="${git_origin_url#*github.com?}"
 repository="${repository%.git}"
+
 if [ "${git_origin_url}" != "[email protected]:apache/iceberg-cpp.git" ]; then
   echo "This script must be ran with a working copy of apache/iceberg-cpp."
   echo "The origin's URL: ${git_origin_url}"
@@ -61,13 +62,22 @@ svn \
 
 svn co "${dist_url}/${release_id}"
 pushd "${release_id}"
+
+echo "Renaming artifacts to their final release names..."
+for fname in ./*; do
+  mv "${fname}" "${fname//-rc${rc}/}"
+done
+echo "Renamed files:"
+ls -l
+
 gh release create "${tag}" \
+  --repo "${repository}" \
   --title "Apache Iceberg C++ ${version}" \
   --generate-notes \
   --verify-tag \
-  ${release_id}.tar.gz \
-  ${release_id}.tar.gz.asc \
-  ${release_id}.tar.gz.sha512
+  *.tar.gz \
+  *.tar.gz.asc \
+  *.tar.gz.sha512
 popd
 
 rm -rf "${release_id}"
@@ -93,11 +103,12 @@ echo
 echo "Add this release to ASF's report database:"
 echo "  https://reporter.apache.org/addrelease.html?iceberg"
 
-echo "Draft email for [email protected] mailing list"
+echo "Draft email for announcement"
 echo ""
 echo "---------------------------------------------------------"
 cat <<MAIL
-To: [email protected]
+To: [email protected]
+Cc: [email protected]
 Hello everyone,
 
 I'm pleased to announce the release of Apache Iceberg C++ v${version}!

dev/release/release_rc.sh

@@ -96,10 +96,11 @@ if [ "${RELEASE_SIGN}" -gt 0 ]; then
 
   mkdir -p "${id}"
 
-  echo "Downloading .tar.gz from GitHub Releases"
+  echo "Downloading .tar.gz and .sha512 from GitHub Releases"
   gh release download "${rc_tag}" \
     --dir "${id}" \
     --pattern "${tar_gz}" \
+    --pattern "${tar_gz}.sha512" \
     --repo "${repository}" \
     --skip-existing
 

src/iceberg/transform.cc

@@ -39,30 +39,6 @@ constexpr std::string_view kHourName = "hour";
 constexpr std::string_view kVoidName = "void";
 }  // namespace
 
-constexpr std::string_view TransformTypeToString(TransformType type) {
-  switch (type) {
-    case TransformType::kUnknown:
-      return kUnknownName;
-    case TransformType::kIdentity:
-      return kIdentityName;
-    case TransformType::kBucket:
-      return kBucketName;
-    case TransformType::kTruncate:
-      return kTruncateName;
-    case TransformType::kYear:
-      return kYearName;
-    case TransformType::kMonth:
-      return kMonthName;
-    case TransformType::kDay:
-      return kDayName;
-    case TransformType::kHour:
-      return kHourName;
-    case TransformType::kVoid:
-      return kVoidName;
-  }
-  std::unreachable();
-}
-
 std::shared_ptr<Transform> Transform::Identity() {
   static auto instance =
       std::shared_ptr<Transform>(new Transform(TransformType::kIdentity));

src/iceberg/transform.h

@@ -23,6 +23,7 @@
 
 #include <cstdint>
 #include <memory>
+#include <utility>
 #include <variant>
 
 #include "iceberg/expression/literal.h"
@@ -57,7 +58,29 @@ enum class TransformType {
 };
 
 /// \brief Get the relative transform name
-ICEBERG_EXPORT constexpr std::string_view TransformTypeToString(TransformType type);
+ICEBERG_EXPORT constexpr std::string_view TransformTypeToString(TransformType type) {
+  switch (type) {
+    case TransformType::kUnknown:
+      return "unknown";
+    case TransformType::kIdentity:
+      return "identity";
+    case TransformType::kBucket:
+      return "bucket";
+    case TransformType::kTruncate:
+      return "truncate";
+    case TransformType::kYear:
+      return "year";
+    case TransformType::kMonth:
+      return "month";
+    case TransformType::kDay:
+      return "day";
+    case TransformType::kHour:
+      return "hour";
+    case TransformType::kVoid:
+      return "void";
+  }
+  std::unreachable();
+}
 
 /// \brief Represents a transform used in partitioning or sorting in Iceberg.
 ///