ci: add clang-tidy Checks

Signed-off-by: Junwang Zhao <[email protected]>

Author: zhjwpku

.clang-tidy

@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+Checks: |
+  -*,
+  clang-diagnostic-*,
+  clang-analyzer-*,
+  google-*,
+  modernize-*,
+  -modernize-use-nodiscard,
+  -modernize-use-trailing-return-type,
+
+CheckOptions:
+  - key:    google-readability-braces-around-statements.ShortStatementLines
+    value:  '1'
+  - key:    google-readability-function-size.StatementThreshold
+    value:  '800'
+  - key:    google-readability-namespace-comments.ShortNamespaceLines
+    value:  '10'
+  - key:    google-readability-namespace-comments.SpacesBeforeComments
+    value:  '2'
+
+HeaderFilterRegex: '(src|test|example)'

example/demo_example.cc

@@ -24,8 +24,8 @@
 #include "iceberg/puffin/demo_puffin.h"
 
 int main() {
-  std::cout << iceberg::DemoTable().print() << std::endl;
-  std::cout << iceberg::puffin::DemoPuffin().print() << std::endl;
-  std::cout << iceberg::arrow::DemoArrow().print() << std::endl;
+  std::cout << iceberg::DemoTable().Print() << std::endl;
+  std::cout << iceberg::puffin::DemoPuffin().Print() << std::endl;
+  std::cout << iceberg::arrow::DemoArrow().Print() << std::endl;
   return 0;
 }

src/iceberg/arrow/demo_arrow.cc

@@ -25,8 +25,8 @@
 
 namespace iceberg::arrow {
 
-std::string DemoArrow::print() const {
-  return DemoTable().print() +
+std::string DemoArrow::Print() const {
+  return DemoTable().Print() +
          ", Arrow version: " + ::arrow::GetBuildInfo().version_string;
 }
 

src/iceberg/arrow/demo_arrow.h

@@ -30,7 +30,7 @@ class ICEBERG_ARROW_EXPORT DemoArrow : public Table {
  public:
   DemoArrow() = default;
   ~DemoArrow() override = default;
-  std::string print() const override;
+  std::string Print() const override;
 };
 
 }  // namespace iceberg::arrow

src/iceberg/demo_table.cc

@@ -23,6 +23,6 @@
 
 namespace iceberg {
 
-std::string DemoTable::print() const { return "DemoTable"; }
+std::string DemoTable::Print() const { return "DemoTable"; }
 
 }  // namespace iceberg

src/iceberg/demo_table.h

@@ -28,7 +28,7 @@ class ICEBERG_EXPORT DemoTable : public Table {
   DemoTable() = default;
   ~DemoTable() override = default;
 
-  std::string print() const override;
+  std::string Print() const override;
 };
 
 }  // namespace iceberg

src/iceberg/puffin.h

@@ -28,7 +28,7 @@ namespace iceberg {
 class ICEBERG_EXPORT Puffin {
  public:
   virtual ~Puffin() = default;
-  virtual std::string print() const = 0;
+  virtual std::string Print() const = 0;
 };
 
 }  // namespace iceberg

src/iceberg/puffin/demo_puffin.cc

@@ -21,6 +21,6 @@
 
 namespace iceberg::puffin {
 
-std::string DemoPuffin::print() const { return "DemoPuffin"; }
+std::string DemoPuffin::Print() const { return "DemoPuffin"; }
 
 }  // namespace iceberg::puffin

src/iceberg/puffin/demo_puffin.h

@@ -28,7 +28,7 @@ class ICEBERG_PUFFIN_EXPORT DemoPuffin : public Puffin {
  public:
   DemoPuffin() = default;
   ~DemoPuffin() override = default;
-  std::string print() const override;
+  std::string Print() const override;
 };
 
 }  // namespace iceberg::puffin

src/iceberg/table.h

@@ -29,7 +29,7 @@ namespace iceberg {
 class ICEBERG_EXPORT Table {
  public:
   virtual ~Table() = default;
-  virtual std::string print() const = 0;
+  virtual std::string Print() const = 0;
 };
 
 }  // namespace iceberg