Skip to content

Commit 6d72f80

Browse files
committed
Merge branch 'primitive-literal-impl' of github.com:mapleFU/iceberg-cpp into primitive-literal-impl
2 parents 694cb55 + 012966f commit 6d72f80

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/iceberg/expression/literal.cc

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ Result<PrimitiveLiteral> PrimitiveLiteralCaster::CastFromInt(
7777
return PrimitiveLiteral::Float(static_cast<float>(int_val));
7878
case TypeId::kDouble:
7979
return PrimitiveLiteral::Double(static_cast<double>(int_val));
80-
// TODO(mwish): Supports casts to date and literal
8180
default:
8281
return NotSupported("Cast from Int to {} is not implemented",
8382
static_cast<int>(target_type_id));
@@ -105,8 +104,8 @@ Result<PrimitiveLiteral> PrimitiveLiteralCaster::CastFromLong(
105104
case TypeId::kDouble:
106105
return PrimitiveLiteral::Double(static_cast<double>(long_val));
107106
default:
108-
return NotImplemented("Cast from Long to {} is not implemented",
109-
static_cast<int>(target_type_id));
107+
return NotSupported("Cast from Long to {} is not supported",
108+
static_cast<int>(target_type_id));
110109
}
111110
}
112111

@@ -119,8 +118,8 @@ Result<PrimitiveLiteral> PrimitiveLiteralCaster::CastFromFloat(
119118
case TypeId::kDouble:
120119
return PrimitiveLiteral::Double(static_cast<double>(float_val));
121120
default:
122-
return NotImplemented("Cast from Float to {} is not implemented",
123-
static_cast<int>(target_type_id));
121+
return NotSupported("Cast from Float to {} is not supported",
122+
static_cast<int>(target_type_id));
124123
}
125124
}
126125

0 commit comments

Comments
 (0)