Skip to content

Commit be17441

Browse files
committed
try to fix windows export
1 parent 79bba23 commit be17441

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

cmake_modules/BuildUtils.cmake

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -215,18 +215,13 @@ function(add_iceberg_lib LIB_NAME)
215215
string(TOUPPER ${LIB_NAME} LIB_NAME_UPPER)
216216
if(BUILD_SHARED)
217217
generate_export_header(${LIB_NAME}_shared BASE_NAME ${LIB_NAME_UPPER})
218-
target_compile_definitions(${LIB_NAME}_shared
219-
PRIVATE ${LIB_NAME}_shared_EXPORTS
220-
PUBLIC ${LIB_NAME_UPPER}_STATIC_DEFINE)
218+
target_compile_definitions(${LIB_NAME}_shared PUBLIC ${LIB_NAME}_shared_EXPORTS)
221219
if(BUILD_STATIC)
222220
target_compile_definitions(${LIB_NAME}_static
223221
PUBLIC ${LIB_NAME_UPPER}_STATIC_DEFINE)
224222
endif()
225223
elseif(BUILD_STATIC)
226224
generate_export_header(${LIB_NAME}_static BASE_NAME ${LIB_NAME_UPPER})
227-
target_compile_definitions(${LIB_NAME}_static
228-
PRIVATE ${LIB_NAME}_static_EXPORTS
229-
PUBLIC ${LIB_NAME_UPPER}_STATIC_DEFINE)
230225
endif()
231226

232227
# Modify variable in calling scope

0 commit comments

Comments
 (0)