fix: make error message consistent with Java impl

Author: zhjwpku

src/iceberg/sort_order.cc

@@ -90,13 +90,13 @@ Status SortOrder::Validate(const Schema& schema) const {
   for (const auto& field : fields_) {
     auto schema_field = schema.FindFieldById(field.source_id());
     if (!schema_field.has_value() || schema_field.value() == std::nullopt) {
-      return InvalidArgument("Cannot find schema field for sort field: {}", field);
+      return InvalidArgument("Cannot find source column for sort field: {}", field);
     }
 
     const auto& source_type = schema_field.value().value().get().type();
 
     if (!field.transform()->CanTransform(*source_type)) {
-      return InvalidArgument("Cannot transform schema field type {} with transform {}",
+      return InvalidArgument("Invalid source type {} for transform {}",
                              source_type->ToString(), field.transform()->ToString());
     }
   }
@@ -116,12 +116,12 @@ Result<std::unique_ptr<SortOrder>> SortOrder::Make(const Schema& schema, int32_t
   for (const auto& field : fields) {
     ICEBERG_ASSIGN_OR_RAISE(auto schema_field, schema.FindFieldById(field.source_id()));
     if (schema_field == std::nullopt) {
-      return InvalidArgument("Cannot find schema field for sort field: {}", field);
+      return InvalidArgument("Cannot find source column for sort field: {}", field);
     }
 
     const auto& source_type = schema_field.value().get().type();
     if (field.transform()->CanTransform(*source_type) == false) {
-      return InvalidArgument("Cannot transform schema field type {} with transform {}",
+      return InvalidArgument("Invalid source type {} for transform {}",
                              source_type->ToString(), field.transform()->ToString());
     }
   }

src/iceberg/sort_order.h

@@ -74,7 +74,7 @@ class ICEBERG_EXPORT SortOrder : public util::Formattable {
 
   /// \brief Validates the sort order against a schema.
   /// \param schema The schema to validate against.
-  /// \return Error status if the sort order is not bound to the schema.
+  /// \return Error status if the sort order has any invalid transform.
   Status Validate(const Schema& schema) const;
 
   /// \brief Create a SortOrder.

src/iceberg/test/sort_order_test.cc

@@ -231,7 +231,7 @@ TEST_F(SortOrderMakeTest, MakeInvalidSortOrderNonPrimitiveField) {
   auto sort_order = SortOrder::Make(
       schema_with_struct, 1, std::vector<SortField>{*sort_field1_, sort_field_invalid});
   EXPECT_THAT(sort_order, IsError(ErrorKind::kInvalidArgument));
-  EXPECT_THAT(sort_order, HasErrorMessage("Cannot transform schema field type"));
+  EXPECT_THAT(sort_order, HasErrorMessage("Invalid source type"));
 }
 
 TEST_F(SortOrderMakeTest, MakeInvalidSortOrderFieldNotInSchema) {
@@ -241,7 +241,7 @@ TEST_F(SortOrderMakeTest, MakeInvalidSortOrderFieldNotInSchema) {
   auto sort_order = SortOrder::Make(
       *schema_, 1, std::vector<SortField>{*sort_field1_, sort_field_invalid});
   EXPECT_THAT(sort_order, IsError(ErrorKind::kInvalidArgument));
-  EXPECT_THAT(sort_order, HasErrorMessage("Cannot find schema field for sort field"));
+  EXPECT_THAT(sort_order, HasErrorMessage("Cannot find source column for sort field"));
 }
 
 TEST_F(SortOrderMakeTest, MakeUnboundSortOrder) {
@@ -254,7 +254,7 @@ TEST_F(SortOrderMakeTest, MakeUnboundSortOrder) {
   auto validate_status = sort_order.value()->Validate(*schema_);
   EXPECT_THAT(validate_status, IsError(ErrorKind::kInvalidArgument));
   EXPECT_THAT(validate_status,
-              HasErrorMessage("Cannot find schema field for sort field"));
+              HasErrorMessage("Cannot find source column for sort field"));
 }
 
 }  // namespace iceberg