feat: add schema conversion to avro schema #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
May 19, 2025
zhjwpku
reviewed
May 19, 2025
| *node = std::make_shared<::avro::NodePrimitive>(::avro::AVRO_FIXED); | ||
| (*node)->setLogicalType(::avro::LogicalType{::avro::LogicalType::UUID}); | ||
| (*node)->setFixedSize(16); | ||
| (*node)->setName(::avro::Name("uuid_fixed")); |
Collaborator
There was a problem hiding this comment.
I'm wondering if the _fixed suffix is needed.
Member
Author
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
Okay then. Will the name be serialized to the Avro file?
| Status Visit(const StructType& type, ::avro::NodePtr* node); | ||
| Status Visit(const ListType& type, ::avro::NodePtr* node); | ||
| Status Visit(const MapType& type, ::avro::NodePtr* node); | ||
| Status Visit(const SchemaField& field, ::avro::NodePtr* node); |
Collaborator
There was a problem hiding this comment.
Should we make this one private, since SchemaField is not a Iceberg type?
Member
Author
There was a problem hiding this comment.
I think this is fine because the file is also internal. We don't want to expose any avro:: and arrow:: namespace.
zhjwpku
approved these changes
May 19, 2025
Fokko
approved these changes
May 19, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.