feat: add avro input&output stream based on arrow stream impl #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwpku
reviewed
May 20, 2025
src/iceberg/avro/avro_stream.cc
Outdated
| #include <format> | ||
|
|
||
| #include <arrow/result.h> | ||
| #include <iceberg/exception.h> |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include <iceberg/exception.h> | |
| #include "iceberg/exception.h" |
For iceberg headers, it's better to use double quote style since it's in the current working directory.
wgtmac
reviewed
May 20, 2025
wgtmac
reviewed
May 21, 2025
yingcai-cy
reviewed
May 21, 2025
wgtmac
approved these changes
May 21, 2025
yingcai-cy
approved these changes
May 21, 2025
Fokko
reviewed
May 21, 2025
|
|
||
| /// \brief "Returns" back some of the data to the stream. The returned data must be less | ||
| /// than what was obtained in the last call to next(). | ||
| void backup(size_t len) override; |
Contributor
There was a problem hiding this comment.
Could you elaborate why we need a backup method when reading Avro? Does not make a lot of sense to me.
Member
There was a problem hiding this comment.
This is a public interface from avro-cpp. IIRC, it internally reads a large chunk into the buffer and then backup some if read too much to reduce I/O.
Fokko
approved these changes
May 21, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
LGTM @dongxiao1198, thanks for the reviews @yingcai-cy, @zhjwpku and @wgtmac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support basic avro stream based on arrow implement