feat: support decompress gzip metadata #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
reviewed
May 23, 2025
wgtmac
reviewed
May 26, 2025
wgtmac
approved these changes
May 26, 2025
yingcai-cy
reviewed
May 26, 2025
wgtmac
reviewed
May 27, 2025
Member
|
@lidavidm @yingcai-cy Do you have any other comment? |
lidavidm
reviewed
May 28, 2025
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
No more comments. I think we will want a bit more abstraction eventually since presumably we will want to support other compression methods but this works for now.
Member
|
Iceberg itself only requires gzip for metadata json file. Specific file format libraries we use for Parquet and Avro have already supported different codecs so we don't need to deal with them in both |
Fokko
approved these changes
May 28, 2025
Contributor
|
LGTM @dongxiao1198 , thanks for the review @wgtmac, @lidavidm and @yingcai-cy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support gzip compressed metadata json