Skip to content

fix: Minor typo fixes #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

fix: Minor typo fixes #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac8358b
Minor typo fixes
Jun 4, 2025
8be414c
Minor fix
Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/iceberg/manifest_list.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace iceberg {

const StructType& PartitionFieldSummary::Type() {
static const StructType kInstance{{
PartitionFieldSummary::kConsTainsNull,
PartitionFieldSummary::kContainsNull,
PartitionFieldSummary::kContainsNaN,
PartitionFieldSummary::kLowerBound,
PartitionFieldSummary::kUpperBound,
Expand Down
2 changes: 1 addition & 1 deletion src/iceberg/manifest_list.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ struct ICEBERG_EXPORT PartitionFieldSummary {
/// values are null or NaN
std::optional<std::vector<uint8_t>> upper_bound;

inline static const SchemaField kConsTainsNull =
inline static const SchemaField kContainsNull =
SchemaField::MakeRequired(509, "contains_null", std::make_shared<BooleanType>(),
"True if any file has a null partition value");
inline static const SchemaField kContainsNaN =
Expand Down
2 changes: 1 addition & 1 deletion src/iceberg/snapshot.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ struct ICEBERG_EXPORT DataOperation {
struct ICEBERG_EXPORT Snapshot {
static constexpr int64_t kInvalidSnapshotId = -1;

/// A unqiue long ID.
/// A unique long ID.
int64_t snapshot_id;
/// The snapshot ID of the snapshot's parent. Omitted for any snapshot with no parent.
std::optional<int64_t> parent_snapshot_id;
Expand Down
8 changes: 5 additions & 3 deletions src/iceberg/table_metadata.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,11 @@ struct ICEBERG_EXPORT MetadataLogEntry {
/// \brief Represents the metadata for an Iceberg table
///
/// Note that it only contains table metadata from the spec. Compared to the Java
/// implementation, missing pieces including: 1) Map<Integer,
/// Schema|PartitionSpec|SortOrder> 2) List<MetadataUpdate> 3) Map<Long, Snapshot> 4)
/// Map<String, SnapshotRef>
/// implementation, missing pieces including:
/// (1) Map<Integer, Schema|PartitionSpec|SortOrder>
/// (2) List<MetadataUpdate>
/// (3) Map<Long, Snapshot>
/// (4) Map<String, SnapshotRef>
struct ICEBERG_EXPORT TableMetadata {
static constexpr int8_t kDefaultTableFormatVersion = 2;
static constexpr int8_t kSupportedTableFormatVersion = 3;
Expand Down
Loading