Skip to content

Conversation

@wgtmac
Copy link
Member

@wgtmac wgtmac commented Jun 24, 2025

No description provided.

@wgtmac wgtmac force-pushed the enable_sanitizer_ci branch 11 times, most recently from 31374f8 to e7a315b Compare June 27, 2025 01:46
Fix memory leak caused by incorrect use of nanaarrow api
@wgtmac wgtmac force-pushed the enable_sanitizer_ci branch from e7a315b to f205782 Compare June 27, 2025 02:04
@wgtmac wgtmac marked this pull request as ready for review June 27, 2025 02:19
@wgtmac
Copy link
Member Author

wgtmac commented Jun 27, 2025

I think I have addressed all memory leaks. Now the CI for sanitizers can be enabled. Please take a look. @lidavidm @raulcd

cc @METONLIULEI

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've validated no failure output was generated/uploaded too
Thanks for working on this @wgtmac

@Fokko Fokko merged commit 295ecf0 into apache:main Jun 27, 2025
7 checks passed
@Fokko
Copy link
Contributor

Fokko commented Jun 27, 2025

Moving this forward, thanks @wgtmac for working on this, and thanks @lidavidm and @raulcd for the review 🚀

lishuxu pushed a commit to lishuxu/iceberg-cpp that referenced this pull request Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants