Skip to content

refactor: add factory functions for primitive types #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2025
Merged

refactor: add factory functions for primitive types #134

merged 2 commits into from
Jul 7, 2025

Conversation

@zhjwpku
Copy link
Collaborator

@zhjwpku zhjwpku commented Jun 30, 2025

No description provided.

@zhjwpku
Copy link
Collaborator Author

zhjwpku commented Jun 30, 2025

Before I touch more code, I'd like to hear your thoughts on these factory functions for primitive types. For decimal and fixed types, return a newly created shared_ptr, while for other types, return a singleton instance.

@wgtmac @lidavidm @gty404 @mapleFU

gty404
gty404 approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@gty404 gty404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mapleFU
mapleFU reviewed Jun 30, 2025
View reviewed changes
@zhjwpku zhjwpku marked this pull request as ready for review July 1, 2025 13:42
@zhjwpku
Copy link
Collaborator Author

zhjwpku commented Jul 1, 2025

The cpp-linter is failing because the Thrift download step failed. I'd appreciate it if you could help trigger a rerun of the action and also take a moment to review the changes. @Fokko @Xuanwo

@zhjwpku zhjwpku force-pushed the add_singleton_for_primitive_type branch from 7ffe3ec to 78093fe Compare July 5, 2025 09:00
Xuanwo
Xuanwo approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zhjwpku for this change, let's move!

@Xuanwo Xuanwo merged commit 0779a52 into apache:main Jul 7, 2025
7 checks passed
@zhjwpku zhjwpku deleted the add_singleton_for_primitive_type branch July 14, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wgtmac wgtmac wgtmac approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

+3 more reviewers

@mapleFU mapleFU mapleFU approved these changes

@lidavidm lidavidm lidavidm approved these changes

@gty404 gty404 gty404 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zhjwpku @lidavidm @wgtmac @Xuanwo @mapleFU @gty404