refactor: Simplify test setup using a common CMake function #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Jul 22, 2025
| INCLUDE_DIR | ||
| "${CMAKE_BINARY_DIR}" | ||
| SRCS | ||
| test_common.cc |
Member
There was a problem hiding this comment.
test_common.cc can also be added by default in the function.
Contributor
Author
There was a problem hiding this comment.
About half of the tests don't use test_common.cc, so I didn’t include it as a default source file.
wgtmac
approved these changes
Jul 23, 2025
Member
|
@lishuxu Could you please help to resolve the conflicts ? Thanks. |
lishuxu
force-pushed
the
feature/test-cmake
branch
from
6451cb0 to
afa050f
Compare
Contributor
Author
OK, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.