feat(parquet): project arrow array for parquet #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
force-pushed
the
project_parquet_data
branch
from
370f1f4 to
99e4a73
Compare
wgtmac
force-pushed
the
project_parquet_data
branch
from
99e4a73 to
3cd3f75
Compare
wgtmac
force-pushed
the
project_parquet_data
branch
from
3cd3f75 to
9fbe44e
Compare
zhjwpku
approved these changes
Aug 14, 2025
mapleFU
reviewed
Aug 14, 2025
| } | ||
|
|
||
| private: | ||
| // TODO(gangwu): make memory pool configurable |
Member
Author
There was a problem hiding this comment.
I don't have well-thought opinion here. ReaderOptions basically cannot expose any Arrow-related concept. Maybe we cannot avoid introducing a MemoryPool interface which is similar to FileIO whose default implementation is backed by Arrow.
dongxiao1198
approved these changes
Aug 15, 2025
gty404
approved these changes
Aug 15, 2025
Member
Author
|
@Fokko @zeroshade Could you help review this? Thanks! |
zeroshade
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.