test: enhance ManifestListReaderV2Test and unified test architecture #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongxiao1198
approved these changes
Aug 12, 2025
wgtmac
approved these changes
Aug 13, 2025
Member
|
The PR title need to be changed to |
HeartLinked
changed the title
for ManifestListReader
- Apply clang-format to fix code style issues - Remove trailing whitespaces - Fix indentation and alignment - Ensure consistent formatting with project standards
- Rename ManifestListReaderTest to ManifestListReaderV2Test - Rename PrepareTestManifestList to PrepareV2PartitionedTestManifestList - Rename BasicTest to PartitionedTest - Rename V2NonPartitionedTest to NonPartitionedTest - Prepare structure for adding V1 tests
- Introduce unified ManifestListReaderTestBase for common functionality - Unify V1 and V2 test class inheritance and setup patterns - Extract test data preparation into dedicated helper methods - Add TestNonPartitionedManifests() helper for validation - Standardize test naming: remove version prefixes, use consistent patterns - Improve code organization and reduce duplication - Maintain all existing test coverage while enhancing maintainability
HeartLinked
force-pushed
the
test_manifest_list_reader_v2
branch
from
d8ada3e to
fa0de35
Compare
HeartLinked
changed the title
Member
|
@Fokko @zeroshade Could you help review this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2 Manifest Format Support
Unified Test Architecture
TempFileTestBasefor uniformityTestManifestListReading()andTestNonPartitionedManifests()utilities