feat: support avro writer #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Aug 13, 2025
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Left some minor comments. Please rebase on the latest main branch to trigger the pre-commit CI (my fix was just merged).
added 2 commits
August 13, 2025 19:38
1 add avro writer and factory(without write func since converter pull/166 not finished yet) 2 add file metrics definition
dongxiao1198
force-pushed
the
avro_writer
branch
from
78b9c8c to
74f61ae
Compare
Contributor
Author
patch rebased |
wgtmac
approved these changes
Aug 13, 2025
Member
zhjwpku
reviewed
Aug 14, 2025
zhjwpku
approved these changes
Aug 14, 2025
Fokko
approved these changes
Aug 14, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This makes sense, thanks @dongxiao1198 for adding this, and thanks @wgtmac and @zhjwpku for the review 🙌
Co-authored-by: Junwang Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 add avro writer and factory(without write func since converter pull/166 not finished yet)
2 add file metrics definition