Skip to content

refactor: enhance forward declarations in type_fwd.h to reduce compile dependencies #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

refactor: enhance forward declarations in type_fwd.h to reduce compile dependencies #187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38b6957
refactor: enhance forward declarations in type_fwd.h to reduce comp…
HeartLinked Aug 21, 2025
fc2a13b
complete
HeartLinked Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/iceberg/type_fwd.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,11 @@ enum class SnapshotRefType;
enum class TransformType;

class Expression;
class Literal;

class DataTableScan;
class FileScanTask;
class ScanTask;
class TableScan;
class TableScanBuilder;

Expand All @@ -125,18 +128,17 @@ struct ManifestEntry;
struct ManifestFile;
struct ManifestList;

class ManifestReader;
class ManifestListReader;
class ManifestListWriter;
class ManifestReader;
class ManifestWriter;

/// ----------------------------------------------------------------------------
/// TODO: Forward declarations below are not added yet.
/// ----------------------------------------------------------------------------
class Reader;
class Writer;

class StructLike;

class MetadataUpdate;
class UpdateRequirement;

class AppendFiles;

} // namespace iceberg
Loading