Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 96 additions & 0 deletions src/iceberg/util/endian.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

#pragma once

#include <bit>
#include <concepts>
#include <cstdint>

/// \file iceberg/util/endian.h
/// \brief Endianness conversion utilities

namespace iceberg {

/// \brief Concept for values that can be converted to/from another endian format.
template <typename T>
concept EndianConvertible = std::is_arithmetic_v<T>;

/// \brief Byte-swap a value. For floating-point types, only support 32-bit and 64-bit
/// floats.
template <EndianConvertible T>
constexpr T ByteSwap(T value) {
if constexpr (sizeof(T) <= 1) {
return value;
} else if constexpr (std::is_integral_v<T>) {
return std::byteswap(value);
} else if constexpr (std::is_floating_point_v<T>) {
if constexpr (sizeof(T) == sizeof(uint16_t)) {
return std::bit_cast<T>(std::byteswap(std::bit_cast<uint16_t>(value)));
} else if constexpr (sizeof(T) == sizeof(uint32_t)) {
return std::bit_cast<T>(std::byteswap(std::bit_cast<uint32_t>(value)));
} else if constexpr (sizeof(T) == sizeof(uint64_t)) {
return std::bit_cast<T>(std::byteswap(std::bit_cast<uint64_t>(value)));
} else {
static_assert(false, "Unsupported floating-point size for endian conversion.");
}
}
}

/// \brief Convert a value to little-endian format.
template <EndianConvertible T>
constexpr T ToLittleEndian(T value) {
if constexpr (std::endian::native == std::endian::little) {
return value;
} else {
return ByteSwap(value);
}
}

/// \brief Convert a value from little-endian format.
template <EndianConvertible T>
constexpr T FromLittleEndian(T value) {
if constexpr (std::endian::native == std::endian::little) {
return value;
} else {
return ByteSwap(value);
}
}

/// \brief Convert a value to big-endian format.
template <EndianConvertible T>
constexpr T ToBigEndian(T value) {
if constexpr (std::endian::native == std::endian::big) {
return value;
} else {
return ByteSwap(value);
}
}

/// \brief Convert a value from big-endian format.
template <EndianConvertible T>
constexpr T FromBigEndian(T value) {
if constexpr (std::endian::native == std::endian::big) {
return value;
} else {
return ByteSwap(value);
}
}

} // namespace iceberg
7 changes: 4 additions & 3 deletions test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,11 @@ add_iceberg_test(json_serde_test

add_iceberg_test(util_test
SOURCES
formatter_test.cc
config_test.cc
visit_type_test.cc
string_util_test.cc)
endian_test.cc
formatter_test.cc
string_util_test.cc
visit_type_test.cc)

if(ICEBERG_BUILD_BUNDLE)
add_iceberg_test(avro_test
Expand Down
87 changes: 87 additions & 0 deletions test/endian_test.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

#include "iceberg/util/endian.h"

#include <array>
#include <cmath>
#include <limits>

#include <gtest/gtest.h>

namespace iceberg {

#define EXPECT_ROUNDTRIP(value) \
do { \
EXPECT_EQ(FromLittleEndian(ToLittleEndian(value)), value); \
EXPECT_EQ(FromBigEndian(ToBigEndian(value)), value); \
} while (false)

TEST(EndianTest, RoundTripPreservesValue) {
EXPECT_ROUNDTRIP(static_cast<uint16_t>(0x1234));
EXPECT_ROUNDTRIP(static_cast<uint32_t>(0xDEADBEEF));
EXPECT_ROUNDTRIP(std::numeric_limits<uint64_t>::max());
EXPECT_ROUNDTRIP(static_cast<uint32_t>(0));

EXPECT_ROUNDTRIP(static_cast<int16_t>(-1));
EXPECT_ROUNDTRIP(static_cast<int32_t>(-0x12345678));
EXPECT_ROUNDTRIP(std::numeric_limits<int64_t>::min());
EXPECT_ROUNDTRIP(std::numeric_limits<int16_t>::max());

EXPECT_ROUNDTRIP(3.14f);
EXPECT_ROUNDTRIP(2.718281828459045);
EXPECT_ROUNDTRIP(0.0f);
EXPECT_ROUNDTRIP(-0.0f);
EXPECT_ROUNDTRIP(0.0);
EXPECT_ROUNDTRIP(-0.0);

EXPECT_ROUNDTRIP(std::numeric_limits<float>::infinity());
EXPECT_ROUNDTRIP(-std::numeric_limits<float>::infinity());
EXPECT_ROUNDTRIP(std::numeric_limits<double>::infinity());
EXPECT_ROUNDTRIP(-std::numeric_limits<double>::infinity());

EXPECT_TRUE(std::isnan(
FromLittleEndian(ToLittleEndian(std::numeric_limits<float>::quiet_NaN()))));
EXPECT_TRUE(
std::isnan(FromBigEndian(ToBigEndian(std::numeric_limits<double>::quiet_NaN()))));
}

TEST(EndianTest, ByteWiseValidation) {
uint32_t original_int = 0x12345678;
uint32_t little_endian_int = ToLittleEndian(original_int);
uint32_t big_endian_int = ToBigEndian(original_int);

auto little_int_bytes = std::bit_cast<std::array<uint8_t, 4>>(little_endian_int);
auto big_int_bytes = std::bit_cast<std::array<uint8_t, 4>>(big_endian_int);

EXPECT_EQ(little_int_bytes, (std::array<uint8_t, 4>{0x78, 0x56, 0x34, 0x12}));
EXPECT_EQ(big_int_bytes, (std::array<uint8_t, 4>{0x12, 0x34, 0x56, 0x78}));

float original_float = 3.14f;
float little_endian_float = ToLittleEndian(original_float);
float big_endian_float = ToBigEndian(original_float);

auto little_float_bytes = std::bit_cast<std::array<uint8_t, 4>>(little_endian_float);
auto big_float_bytes = std::bit_cast<std::array<uint8_t, 4>>(big_endian_float);

EXPECT_EQ(little_float_bytes, (std::array<uint8_t, 4>{0xC3, 0xF5, 0x48, 0x40}));
EXPECT_EQ(big_float_bytes, (std::array<uint8_t, 4>{0x40, 0x48, 0xF5, 0xC3}));
}

} // namespace iceberg
Loading