-
Notifications
You must be signed in to change notification settings - Fork 67
Add GitHub cpp-linter-action #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| name: C++ Linter | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths-ignore: | ||
| - '.github/**' | ||
| - 'ci/**' | ||
| - 'cmake_modules/**' | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| cpp-linter: | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: cpp-linter/[email protected] | ||
| id: linter | ||
| continue-on-error: true | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| style: file | ||
| tidy-checks: file | ||
| files-changed-only: true | ||
| lines-changed-only: true | ||
| thread-comments: true | ||
| ignore: 'build|cmake_modules|ci' | ||
| database: build/compile_commands.json | ||
| extra-args: '-std=c++20 -Wall' | ||
| - name: Fail fast?! | ||
| if: steps.linter.outputs.checks-failed != 0 | ||
| run: | | ||
| echo "some linter checks failed. ${{ steps.linter.outputs.checks-failed }}" | ||
| exit 1 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ | |
| # under the License. | ||
|
|
||
| name: "Run License Check" | ||
|
|
||
| on: pull_request | ||
|
|
||
| jobs: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
|
|
@@ -19,16 +19,25 @@ | |
|
|
||
| #pragma once | ||
|
|
||
| #include <memory> | ||
| #include <string_view> | ||
|
|
||
|
||
|
|
||
|
|
||
| #include <string_view> | ||
|
|
||
| namespace iceberg { | ||
|
|
||
| class Table { | ||
| public: | ||
| virtual ~Table() = default; | ||
| virtual std::string_view print() const = 0; | ||
| static std::unique_ptr<Table> create(); | ||
| class Table { | ||
| public: | ||
| virtual ~Table( ) = default; | ||
|
|
||
| virtual std::string_view print() const = 0; | ||
|
|
||
|
|
||
| static std::unique_ptr<Table> create(); | ||
|
|
||
| private: | ||
| int SOME_ID = 1; | ||
| }; | ||
|
|
||
| } // namespace iceberg | ||
Uh oh!
There was an error while loading. Please reload this page.