feat: support installed nlohmann-json and nanoarrow #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullccxsy
force-pushed
the
feature/dependency-local-search
branch
from
b7cc87d to
fcfa820
Compare
wgtmac
reviewed
Sep 5, 2025
nullccxsy
force-pushed
the
feature/dependency-local-search
branch
from
acfe818 to
597be65
Compare
wgtmac
reviewed
Sep 6, 2025
nullccxsy
force-pushed
the
feature/dependency-local-search
branch
2 times, most recently
from
34cef75 to
d3908b0
Compare
- Updated the dependencies installation command to include `nlohmann-json` and `nanoarrow`. - Refactored the `IcebergThirdpartyToolchain.cmake` to improve handling of `nanoarrow` and `nlohmann_json` dependencies, allowing for better integration and installation based on their availability.
nullccxsy
force-pushed
the
feature/dependency-local-search
branch
from
d3908b0 to
b55bbf3
Compare
added 2 commits
September 11, 2025 22:06
- Updated CMakeLists.txt to conditionally include `nanoarrow` and `nlohmann_json` based on their availability, improving flexibility in dependency handling.
nullccxsy
force-pushed
the
feature/dependency-local-search
branch
from
91ac97a to
0830202
Compare
wgtmac
approved these changes
Sep 12, 2025
nullccxsy
force-pushed
the
feature/dependency-local-search
branch
3 times, most recently
from
bd7061c to
634d6c9
Compare
nullccxsy
force-pushed
the
feature/dependency-local-search
branch
from
634d6c9 to
2053549
Compare
wgtmac
approved these changes
Sep 15, 2025
Member
|
Could you help rename the title to |
nullccxsy
changed the title
Contributor
Author
fixed |
Fokko
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nlohmann-jsonandnanoarrow.IcebergThirdpartyToolchain.cmaketo improve handling ofnanoarrowandnlohmann_jsondependencies, allowing for better integration and installation based on their availability.