feat: define table properties with default values #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
force-pushed
the
table_prop
branch
2 times, most recently
from
6723d40 to
30b86fe
Compare
Just copied everything from the TableProperties.java as of today
Fokko
reviewed
Sep 30, 2025
| "write.delete.avro.compression-level", ""}; | ||
|
|
||
| // ORC properties | ||
| inline static Entry<int64_t> kOrcStripeSizeBytes{"write.orc.stripe-size-bytes", |
Contributor
There was a problem hiding this comment.
Why are we going with int64 here, and with int32 in Parquet? Int32 seems to be sufficient?
Member
Author
There was a problem hiding this comment.
These align with the Java definitions.
Fokko
reviewed
Sep 30, 2025
src/iceberg/table_properties.h
Outdated
Comment on lines
245
to
246
| inline static Entry<bool> kSnapshotIdInheritanceEnabled{ | ||
| "compatibility.snapshot-id-inheritance.enabled", false}; |
Contributor
There was a problem hiding this comment.
I would not backport this part. It was used before V2 was released to test out the snapshot inheritance, but I don't think anyone is really using it since upgrading to V2 is easier.
Member
Author
There was a problem hiding this comment.
Just removed it. Thanks for the information!
Fokko
approved these changes
Sep 30, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Left two minor comments, but apart from that this looks good to me 👍
wgtmac
commented
Sep 30, 2025
Contributor
|
Nice one, thanks for adding this @wgtmac 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just copied everything from the TableProperties.java as of today