Skip to content

fix: fix dir name in verify script #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

fix: fix dir name in verify script #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/release/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ done

if [ "$#" -ne 2 ]; then
echo "Usage: $0 <version> <rc>"
echo " e.g.: $0 0.1.0 1"
echo " e.g.: $0 0.1.0 0"
exit 1
fi

Expand Down
2 changes: 1 addition & 1 deletion dev/release/release_rc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ SOURCE_TOP_DIR="$(cd "${SOURCE_DIR}/../../" && pwd)"

if [ "$#" -ne 2 ]; then
echo "Usage: $0 <version> <rc>"
echo " e.g.: $0 0.1.0 1"
echo " e.g.: $0 0.1.0 0"
exit 1
fi

Expand Down
7 changes: 3 additions & 4 deletions dev/release/verify_rc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ TOP_SOURCE_DIR="$(dirname "$(dirname "${SOURCE_DIR}")")"

if [ "$#" -ne 2 ]; then
echo "Usage: $0 <version> <rc>"
echo " e.g.: $0 0.1.0 1"
echo " e.g.: $0 0.1.0 0"
exit 1
fi

Expand All @@ -42,8 +42,7 @@ VERSION="$1"
RC="$2"

ICEBERG_DIST_BASE_URL="https://downloads.apache.org/iceberg"
RC_BASE_DIR="apache-iceberg-cpp-${VERSION}-rc${RC}"
DOWNLOAD_RC_BASE_URL="https://dist.apache.org/repos/dist/dev/iceberg/${RC_BASE_DIR}"
DOWNLOAD_RC_BASE_URL="https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-cpp-${VERSION}-rc${RC}"
ARCHIVE_BASE_NAME="apache-iceberg-cpp-${VERSION}"

: "${VERIFY_DEFAULT:=1}"
Expand Down Expand Up @@ -143,7 +142,7 @@ cd "${VERIFY_TMPDIR}"
import_gpg_keys
fetch_archive
ensure_source_directory
pushd "${RC_BASE_DIR}"
pushd "${ARCHIVE_BASE_NAME}"
test_source_distribution
popd

Expand Down
Loading