feat: lazy init for Schema and StructType #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Type - Added move and copy constructors and assignment operators for Schema and StructType to manage resource ownership and improve performance. - Refactored field lookup methods to utilize lazy initialization with thread safety, ensuring safe concurrent access. - Introduced unit tests for thread safety in Schema and StructType, validating concurrent operations and access patterns.
…/move operations - Removed copy and move constructors and assignment operators from Schema and StructType to streamline resource management.
nullccxsy
changed the title
wgtmac
reviewed
Sep 16, 2025
Fokko
changed the title
Fokko
approved these changes
Sep 22, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Looks good, thanks @nullccxsy for working on this. In practice, we don't look up by (lowercase) name, and most of the lookups are by Field-ID. So it is good to have these initialize in a lazy fashion 👍
Contributor
|
Thanks @wgtmac for the review 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Type