-
Notifications
You must be signed in to change notification settings - Fork 70
add iceberg_avro interface #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
162bac1 to
a670e0b
Compare
|
@wgtmac Sadly I came across a Windows ci build issue, I don't have a Windows PC, it would be great if you could help to resolve this problem. The problem is two folds:
The compile error is as below, see [1] for details, [2] says it is probably an optimization error, I could not go further because I don't have a windows PC ;( [1] https://github.com/zhjwpku/iceberg-cpp/actions/runs/12842821805/job/35814127788 |
This closes apache#17 The avro_unittest is added for testing if libavrocpp works, once we supported Manifest, this should be removed. Signed-off-by: Junwang Zhao <[email protected]>
|
Thanks @zhjwpku for working on this! I will have a try early next week. Update:
|
b5a5fc7 to
ae99acd
Compare
Signed-off-by: Junwang Zhao <[email protected]>
Signed-off-by: Junwang Zhao <[email protected]>
Signed-off-by: Junwang Zhao <[email protected]>
Add iceberg_avro library
minor fix
wgtmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (Disclaimer: I have pushed some changes to make the CI happy)
Thanks @zhjwpku for taking this work!
This is ready for review @raulcd @lidavidm @gaborkaszab
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add iceberg_avro interface, this closes #17