-
Notifications
You must be signed in to change notification settings - Fork 74
test: add rest catalog integration test #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb22743 to
19b9859
Compare
HuaHuaY
reviewed
Nov 28, 2025
wgtmac
reviewed
Dec 1, 2025
Member
wgtmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just ran it on my MacOS and fall test cases failed.
[==========] Running 2 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 2 tests from RestCatalogIntegrationTest
[INFO] Starting to docker compose up, command: docker compose -p iceberg-rest-catalog-service up -d --wait --timeout 60
Network iceberg-rest-catalog-service_rest_bridge Creating
Network iceberg-rest-catalog-service_rest_bridge Created
Container iceberg-rest-catalog-service-rest-1 Creating
Container iceberg-rest-catalog-service-rest-1 Created
Container iceberg-rest-catalog-service-rest-1 Starting
Container iceberg-rest-catalog-service-rest-1 Started
Container iceberg-rest-catalog-service-rest-1 Waiting
Container iceberg-rest-catalog-service-rest-1 Healthy
[INFO] docker compose up succeed!
[INFO] Waiting for REST catalog to be ready at localhost:8181...
[INFO] REST catalog is ready!
[ RUN ] RestCatalogIntegrationTest.MakeCatalogSuccess
/Users/gangwu/Projects/iceberg-cpp/src/iceberg/test/rest_catalog_test.cc:136: Failure
Value of: catalog_result
Expected: is an Ok result
Actual: 40-byte object <0F-00 00-00 00-00 00-00 20-C0 74-03 00-60 00-00 1D-00 00-00 00-00 00-00 20-00 00-00 00-00 00-80 00-00 00-00 00-00 00-00>, which contains error: Failed to parse JSON string:
[ FAILED ] RestCatalogIntegrationTest.MakeCatalogSuccess (53 ms)
[ RUN ] RestCatalogIntegrationTest.ListNamespaces
/Users/gangwu/Projects/iceberg-cpp/src/iceberg/test/rest_catalog_test.cc:144: Failure
Value of: catalog_result
Expected: is an Ok result
Actual: 40-byte object <0F-00 00-00 01-00 00-00 00-80 74-03 00-60 00-00 1D-00 00-00 00-00 00-00 20-00 00-00 00-00 00-80 00-C0 74-03 00-60 00-00>, which contains error: Failed to parse JSON string:
[ FAILED ] RestCatalogIntegrationTest.ListNamespaces (34 ms)
[ DISABLED ] RestCatalogIntegrationTest.DISABLED_GetNonExistentNamespace
[ DISABLED ] RestCatalogIntegrationTest.DISABLED_CreateAndDropNamespace
[ DISABLED ] RestCatalogIntegrationTest.DISABLED_UpdateNamespaceProperties
[ DISABLED ] RestCatalogIntegrationTest.DISABLED_FullNamespaceWorkflow
[INFO] Starting to docker compose down, command: docker compose -p iceberg-rest-catalog-service down -v --remove-orphans
Container iceberg-rest-catalog-service-rest-1 Stopping
Container iceberg-rest-catalog-service-rest-1 Stopped
Container iceberg-rest-catalog-service-rest-1 Removing
Container iceberg-rest-catalog-service-rest-1 Removed
Network iceberg-rest-catalog-service_rest_bridge Removing
Network iceberg-rest-catalog-service_rest_bridge Removed
[INFO] docker compose down succeed!
[----------] 2 tests from RestCatalogIntegrationTest (87 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test suite ran. (4975 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] RestCatalogIntegrationTest.MakeCatalogSuccess
[ FAILED ] RestCatalogIntegrationTest.ListNamespaces
wgtmac
reviewed
Dec 2, 2025
e82c13a to
962c65b
Compare
wgtmac
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration testing infrastructure for the REST Catalog:
docker-compose.yml) for running a real REST catalog servercmd_util.cc/h) - run cli commandsdocker_compose_util.cc/h) - managing containerized servicessrc/iceberg/test/util/directory.close #333 .