Skip to content

refactor: use std::ranges::to in ToUpper and ToLower #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 1 commit into from
Dec 2, 2025
Merged

refactor: use std::ranges::to in ToUpper and ToLower #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/iceberg/util/string_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,13 @@ namespace iceberg {
class ICEBERG_EXPORT StringUtils {
public:
static std::string ToLower(std::string_view str) {
std::string input(str);
// TODO(xiao.dong) gcc 13.3 didn't support std::ranges::to
std::transform(input.begin(), input.end(), input.begin(), // NOLINT
[](char c) { return std::tolower(c); }); // NOLINT
return input;
return str | std::ranges::views::transform([](char c) { return std::tolower(c); }) |
std::ranges::to<std::string>();
}

static std::string ToUpper(std::string_view str) {
std::string input(str);
// TODO(xiao.dong) gcc 13.3 didn't support std::ranges::to
std::transform(input.begin(), input.end(), input.begin(), // NOLINT
[](char c) { return std::toupper(c); }); // NOLINT
return input;
return str | std::ranges::views::transform([](char c) { return std::toupper(c); }) |
std::ranges::to<std::string>();
}

static bool EqualsIgnoreCase(std::string_view lhs, std::string_view rhs) {
Expand Down
Loading