feat: Impl InMemoryCatalog's UpdateTable

[WZhuo]

No description provided.

[zhjwpku]

LGTM

[zhjwpku]

Suggested change

	while (!result.ends_with("://") && result.ends_with("/")) {
	while (result.ends_with("/") && !result.ends_with("://")) {

This might short circuit more quickly, not a strong opinion though.

[HuaHuaY]

Suggested change

	base->metadata_file_location = metadata_location;
	base->metadata_file_location = std::move(metadata_location);

[HuaHuaY]

Suggested change

	std::unique_lock lock(mutex_);
	std::lock_guard guard(mutex_);

Use std::lock_guard instead of std::unique_lock if we don't need to move the guard.

[HuaHuaY]

Suggested change

	TableIdentifier const& table_ident, std::string const& metadata_location) {
	const TableIdentifier& table_ident, const std::string& metadata_location) {

I think it's better to keep the same style const T& as function declaration.

[HuaHuaY]

How about using reference instead of raw pointer?

[HuaHuaY]

static constexpr is implicitly inline and we can remove inline here.

[HuaHuaY]

Suggested change

	delete_after_commit = StringUtils::ToLower(it->second) == "true" || it->second == "1";
	delete_after_commit = StringUtils::EqualsIgnoreCase(it->second, "true") || it->second == "1";

StringUtils::ToLower allocates new memory and StringUtils::EqualsIgnoreCase doesn't.

[HuaHuaY]

Suggested change

	std::ranges::for_each(
	base->metadata_log |
	std::views::filter(
	[current_files =
	metadata->metadata_log |
	std::ranges::to<std::unordered_set<MetadataLogEntry,
	MetadataLogEntry::Hasher>>()](
	const auto& entry) { return !current_files.contains(entry); }),
	[&io](const auto& entry) { auto status = io.DeleteFile(entry.metadata_file); });
	auto current_files =
	metadata->metadata_log |
	std::ranges::to<std::unordered_set<MetadataLogEntry, MetadataLogEntry::Hasher>>();
	std::ranges::for_each(
	base->metadata_log | std::views::filter([&current_files](const auto& entry) {
	return !current_files.contains(entry);
	}),
	[&io](const auto& entry) { std::ignore = io.DeleteFile(entry.metadata_file); });

[HuaHuaY]

If we ensure there are only numbers here, we can use std::from_chars here. It doesn't need to use substr to create a new string and is faster than std::stoi.

#include <charconv>

int result;
if (std::from_chars(metadata_location.data() + version_start,
                    metadata_location.data() + version_end, result)
        .ec == std::errc()) {
  return result;
} else {
  return -1;
}

[HuaHuaY]

Suggested change

	std::string codec_name = "none";
	std::string_view codec_name = "none";

[HuaHuaY]

ditto