Make field repr explicit about optionality, add exception type #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Feb 4, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks for adding the optional 👍
Co-authored-by: Fokko Driesprong <[email protected]>
wgtmac
approved these changes
Feb 5, 2025
mapleFU
approved these changes
Feb 6, 2025
Member
Author
|
Any more comments here? |
Member
Xuanwo
approved these changes
Feb 18, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you all, I like the iceberg::IcebergError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtual ~Foo() = default->~Foo() override = default, missingexplicit)iceberg::IcebergErrorinstead ofstd::runtime_error(optional)