-
Notifications
You must be signed in to change notification settings - Fork 69
refactor: simplify library management #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Libraries are consolidated to libiceberg and libiceberg-bundle
|
FTR, current install directory on my MacOS looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the library management by consolidating the libraries into libiceberg and libiceberg-bundle, and updates the corresponding build instructions.
- Updated the section title in the README from "Build and Install Iceberg Arrow Library" to "Build and Install Iceberg Bundle Library".
- Adjusted the CMake flags: replacing ICEBERG_ARROW with ICEBERG_BUILD_BUNDLE for both vendored and provided Apache Arrow configurations.
Files not reviewed (18)
- CMakeLists.txt: Language not supported
- cmake_modules/IcebergThirdpartyToolchain.cmake: Language not supported
- example/CMakeLists.txt: Language not supported
- example/demo_example.cc: Language not supported
- src/iceberg/CMakeLists.txt: Language not supported
- src/iceberg/IcebergConfig.cmake.in: Language not supported
- src/iceberg/arrow/CMakeLists.txt: Language not supported
- src/iceberg/arrow/demo_arrow.h: Language not supported
- src/iceberg/avro/CMakeLists.txt: Language not supported
- src/iceberg/avro/demo_avro.h: Language not supported
- src/iceberg/demo.cc: Language not supported
- src/iceberg/puffin.h: Language not supported
- src/iceberg/puffin/CMakeLists.txt: Language not supported
- src/iceberg/puffin/demo_puffin.cc: Language not supported
- src/iceberg/puffin/demo_puffin.h: Language not supported
- src/iceberg/util/CMakeLists.txt: Language not supported
- test/CMakeLists.txt: Language not supported
- test/arrow/CMakeLists.txt: Language not supported
zhjwpku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
|
@wgtmac Sure thing, LGTM! |
Libraries are consolidated to
libicebergandlibiceberg-bundle