Skip to content

Conversation

@wgtmac
Copy link
Member

@wgtmac wgtmac commented Mar 27, 2025

Libraries are consolidated to libiceberg and libiceberg-bundle

Libraries are consolidated to libiceberg and libiceberg-bundle
@wgtmac
Copy link
Member Author

wgtmac commented Mar 27, 2025

FTR, current install directory on my MacOS looks like

/tmp/iceberg/
├── lib/
│   ├── libiceberg_vendored_arrow.a
│   ├── libiceberg_vendored_avrocpp.a
│   ├── libiceberg_vendored_nanoarrow.a
│   ├── libiceberg.dylib
│   ├── libiceberg.a
│   ├── libiceberg_bundle.dylib
│   ├── libiceberg_bundle.a
│   └── cmake/
│       └── Iceberg/
│           ├── IcebergConfig.cmake
│           ├── IcebergConfigVersion.cmake
│           ├── IcebergTargets.cmake
│           └── IcebergTargets-debug.cmake
├── include/
│   └── iceberg/
│       ├── arrow_c_data.h
│       ├── avro.h
│       ├── catalog.h
│       ├── demo.h
│       ├── error.h
│       ├── exception.h
│       ├── expected.h
│       ├── location_provider.h
│       ├── schema.h
│       ├── schema_field.h
│       ├── table.h
│       ├── table_identifier.h
│       ├── transaction.h
│       ├── type.h
│       ├── type_fwd.h
│       ├── iceberg_export.h
│       ├── util/
│       │   ├── formattable.h
│       │   └── formatter.h
│       ├── arrow/
│       │   └── demo_arrow.h
│       ├── avro/
│       │   └── demo_avro.h
│       └── iceberg_bundle_export.h
└── share/
    └── doc/
        └── Iceberg/
            ├── LICENSE
            └── NOTICE

@wgtmac wgtmac requested a review from Copilot March 27, 2025 02:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the library management by consolidating the libraries into libiceberg and libiceberg-bundle, and updates the corresponding build instructions.

  • Updated the section title in the README from "Build and Install Iceberg Arrow Library" to "Build and Install Iceberg Bundle Library".
  • Adjusted the CMake flags: replacing ICEBERG_ARROW with ICEBERG_BUILD_BUNDLE for both vendored and provided Apache Arrow configurations.
Files not reviewed (18)
  • CMakeLists.txt: Language not supported
  • cmake_modules/IcebergThirdpartyToolchain.cmake: Language not supported
  • example/CMakeLists.txt: Language not supported
  • example/demo_example.cc: Language not supported
  • src/iceberg/CMakeLists.txt: Language not supported
  • src/iceberg/IcebergConfig.cmake.in: Language not supported
  • src/iceberg/arrow/CMakeLists.txt: Language not supported
  • src/iceberg/arrow/demo_arrow.h: Language not supported
  • src/iceberg/avro/CMakeLists.txt: Language not supported
  • src/iceberg/avro/demo_avro.h: Language not supported
  • src/iceberg/demo.cc: Language not supported
  • src/iceberg/puffin.h: Language not supported
  • src/iceberg/puffin/CMakeLists.txt: Language not supported
  • src/iceberg/puffin/demo_puffin.cc: Language not supported
  • src/iceberg/puffin/demo_puffin.h: Language not supported
  • src/iceberg/util/CMakeLists.txt: Language not supported
  • test/CMakeLists.txt: Language not supported
  • test/arrow/CMakeLists.txt: Language not supported

Copy link
Collaborator

@zhjwpku zhjwpku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@wgtmac
Copy link
Member Author

wgtmac commented Mar 27, 2025

Thanks @lidavidm @zhjwpku!

Could you help merge this? @Fokko @Xuanwo

@Fokko Fokko merged commit 829dc65 into apache:main Mar 27, 2025
6 checks passed
@Fokko
Copy link
Contributor

Fokko commented Mar 27, 2025

@wgtmac Sure thing, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants