feat: convert arrow schema to iceberg schema #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
force-pushed
the
from_arrow_schema
branch
2 times, most recently
from
524fa68 to
0f4faef
Compare
Member
Author
zhjwpku
reviewed
Apr 1, 2025
wgtmac
force-pushed
the
from_arrow_schema
branch
from
0f4faef to
d4c0068
Compare
lidavidm
approved these changes
Apr 2, 2025
Fokko
approved these changes
Apr 3, 2025
|
|
||
| int32_t GetFieldId(const ArrowSchema& schema) { | ||
| if (schema.metadata == nullptr) { | ||
| return kUnknownFieldId; |
Contributor
There was a problem hiding this comment.
I think this is fine for now. Later on, we can fetch the field IDs from name mapping if they are not in the metadata. Or we can assign fresh IDs in case we want to create a new table from an Arrow schema 👍
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.