Skip to content

Conversation

@zhjwpku
Copy link
Collaborator

@zhjwpku zhjwpku commented Apr 2, 2025

No description provided.

Signed-off-by: Junwang Zhao <[email protected]>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality for sorting by implementing new SortOrder and SortField classes along with comprehensive tests.

  • Implements SortOrder and SortField classes with formatting and equality comparison.
  • Provides tests to validate sort order behavior and proper string output.
  • Adds a custom TransformFunction for testing purposes.

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/sort_order_test.cc Adds tests for basic functionality and equality for SortOrder.
test/sort_field_test.cc Adds tests for basic functionality and equality for SortField.
src/iceberg/sort_order.h Declares the SortOrder class with defined formatting and equality.
src/iceberg/sort_order.cc Implements SortOrder with string formatting and equality check.
src/iceberg/sort_field.h Declares the SortField class with string formatting and equality.
src/iceberg/sort_field.cc Implements SortField with formatting and equality check.
Files not reviewed (2)
  • src/iceberg/CMakeLists.txt: Language not supported
  • test/CMakeLists.txt: Language not supported

@zhjwpku zhjwpku requested a review from lidavidm April 3, 2025 02:05
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhjwpku
Copy link
Collaborator Author

zhjwpku commented Apr 3, 2025

@Fokko @Xuanwo Please take a look at this PR when you are available, thanks ;)

@wgtmac
Copy link
Member

wgtmac commented Apr 8, 2025

Do you have any comment? @lidavidm

@Fokko Fokko merged commit 47549a9 into apache:main Apr 8, 2025
6 checks passed
@Fokko
Copy link
Contributor

Fokko commented Apr 8, 2025

Thanks @zhjwpku for working on this, and thanks @wgtmac, @lidavidm and @gty404 for the reviews 🙌

@zhjwpku zhjwpku deleted the sort_order branch April 14, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants