refactor: add expression subdirectory #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwpku
approved these changes
Apr 18, 2025
| return unexpected<Error>({.kind = ErrorKind::kInvalidExpression, | ||
| .message = std::format(fmt, std::forward<Args>(args)...)}); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Should we add an Error wrapper for each ErrorKind? I'd suggest including all those in this PR if needed. #80 might need NoSuchNamespaceError.
Member
Author
There was a problem hiding this comment.
That's a good idea! We can use a separate PR for this.
yingcai-cy
approved these changes
Apr 18, 2025
Contributor
yingcai-cy
left a comment
yingcai-cy
left a comment
There was a problem hiding this comment.
Thanks for doing this.
Xuanwo
approved these changes
Apr 18, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
The community has reached a consensus. Let’s move forward!
Member
Author
|
Thank you @Xuanwo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.