test: add table metadata deserialization test #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wgtmac
commented
Apr 18, 2025
wgtmac
commented
- Added a set of test files from https://github.com/apache/iceberg/tree/main/core/src/test/resources
- Fixed table metadata deserialization
- Added singleton for unsorted sort order and unpartitioned spec
- Added test case for deserializing valid v1 and v2 metadata files
wgtmac
force-pushed
the
add_metadata_json_test
branch
3 times, most recently
from
0bd62f2 to
098e848
Compare
wgtmac
force-pushed
the
add_metadata_json_test
branch
from
098e848 to
9c096d6
Compare
zhjwpku
suggested changes
Apr 19, 2025
gty404
reviewed
Apr 19, 2025
src/iceberg/table_metadata.cc
Outdated
| } | ||
|
|
||
| const std::shared_ptr<Schema>& TableMetadata::Schema() const { | ||
| static const std::shared_ptr<::iceberg::Schema> empty_schema = nullptr; |
Contributor
There was a problem hiding this comment.
Why not return a truly empty schema object, but null?
Collaborator
There was a problem hiding this comment.
I once had the same concern, but this method returns a reference, I guess that's the reason?
Member
Author
There was a problem hiding this comment.
I switched to wrap the return in a Result so we can get an explicit NotFound error.
Fokko
approved these changes
Apr 20, 2025
| rev: v19.1.5 | ||
| hooks: | ||
| - id: clang-format | ||
| exclude: ^test/resources/.*\.json$ |
Contributor
There was a problem hiding this comment.
Does clang want to format json? 🤔
Member
Author
There was a problem hiding this comment.
Yes, without this change the pre-commit fails and complains that clang-format does not support JSON file.
Xuanwo
approved these changes
Apr 21, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
The community has reached a consensus. Let's move forward!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.