chore: use chrono::milliseconds in snapshot and consolidate error usage #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Apr 19, 2025
zhjwpku
force-pushed
the
snapshot_chrono_ms
branch
from
31a3cf5 to
22adecf
Compare
lidavidm
approved these changes
Apr 21, 2025
reduce direct unexpected usage by using more Error wrappers defined in result.h Signed-off-by: Junwang Zhao <[email protected]>
Signed-off-by: Junwang Zhao <[email protected]>
zhjwpku
force-pushed
the
snapshot_chrono_ms
branch
from
31cc38b to
0dc4c11
Compare
Signed-off-by: Junwang Zhao <[email protected]>
zhjwpku
force-pushed
the
snapshot_chrono_ms
branch
from
0dc4c11 to
ff33b9a
Compare
wgtmac
approved these changes
Apr 21, 2025
Collaborator
Author
Fokko
approved these changes
Apr 22, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce direct unexpected usage by using more Error wrappers defined in result.h