feat: add table metadata reader and writer #85
Conversation
wgtmac
force-pushed
the
add_metadata_reader
branch
from
cb375f1 to
096cd4c
Compare
wgtmac
changed the title
| Result<nlohmann::json> FromJsonString(const std::string& json_string) { | ||
| try { | ||
| return nlohmann::json::parse(json_string); | ||
| } catch (const std::exception& e) { |
There was a problem hiding this comment.
nit:should we only catch json::parse_error exception?
There was a problem hiding this comment.
I agree that the official documentation says it only throws parse_error. I just want to be safe enough to catch all just in case. Or we can add a special branch for parse_error for better error message.
There was a problem hiding this comment.
You can also call an overload that doesn't throw an exception, and explicitly check whether the resulting JSON object is discarded() (IIRC)
| return false; | ||
| } | ||
| for (size_t i = 0; i < lhs.size(); ++i) { | ||
| if (*lhs[i] != *rhs[i]) { |
There was a problem hiding this comment.
It could be null if there is something wrong. Since operator== is only used in the test case, it should be fine. I can add a NullSafeEquals later if this is required.
|
Thanks @wgtmac for working on this, and thanks @lidavidm, @zhjwpku and @yingcai-cy for the review 🙌 |
5 participants
No description provided.