feat: enable arrow to build parquet #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
commented
Apr 26, 2025
| ${FC_DECLARE_COMMON_OPTIONS} | ||
| URL ${ARROW_SOURCE_URL} | ||
| URL_HASH "SHA256=${ICEBERG_ARROW_BUILD_SHA256_CHECKSUM}" | ||
| GIT_REPOSITORY https://github.com/wgtmac/arrow.git |
Member
Author
There was a problem hiding this comment.
This is still on my fork: apache/arrow#46232. Will update it once merged and released.
kou
pushed a commit
to apache/arrow
that referenced
this pull request
Apr 28, 2025
…lly accessible by FetchContent (#46232) ### Rationale for this change `arrow_bundled_dependencies` is an IMPORTED library which links to `arrow_bundled_dependencies_merge`. When arrow-cpp is used externally as a third-party dependency via CMake `FetchContent`, target `arrow_bundled_dependencies` is not accessible by the parent project (but `arrow_bundled_dependencies_merge` is). It is difficult for the parent project to locate the built product of `arrow_bundled_dependencies_merge` and install it. ### What changes are included in this PR? Change `IMPORTED` library `arrow_bundled_dependencies` to be `GLOBAL`. ### Are these changes tested? - Pass all CIs. - Verified to work by apache/iceberg-cpp#89 ### Are there any user-facing changes? I don't think so. * GitHub Issue: #46231 Authored-by: Gang Wu <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Fokko
approved these changes
Apr 29, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.